From: Ben Draut <drautb@gmail.com>
Date: Fri, 13 Apr 2018 21:43:04 +0000 (-0600)
Subject: MINOR: config: Warn if resolvers has no nameservers
X-Git-Tag: v1.9-dev1~304
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=054fbee67a6e7bc7d396027ecc901f88255302cf;p=thirdparty%2Fhaproxy.git

MINOR: config: Warn if resolvers has no nameservers

Today, a `resolvers` section may be configured without any `nameserver`
directives, which is useless. This implements a warning when such
sections are detected.

[List thread][1].

[1]: https://www.mail-archive.com/haproxy@formilux.org/msg29600.html
---

diff --git a/src/cfgparse.c b/src/cfgparse.c
index 37bbf45313..621af6c814 100644
--- a/src/cfgparse.c
+++ b/src/cfgparse.c
@@ -7336,6 +7336,7 @@ int check_config_validity()
 	struct bind_conf *bind_conf;
 	char *err;
 	struct cfg_postparser *postparser;
+	struct dns_resolvers *curr_resolvers = NULL;
 
 	bind_conf = NULL;
 	/*
@@ -8976,6 +8977,15 @@ out_uri_auth_compat:
 				    global.tune.max_http_hdr * sizeof(struct hdr_idx_elem),
 				    MEM_F_SHARED);
 
+	list_for_each_entry(curr_resolvers, &dns_resolvers, list) {
+		if (LIST_ISEMPTY(&curr_resolvers->nameservers)) {
+			ha_warning("config : resolvers '%s' [%s:%d] has no nameservers configured!\n",
+				   curr_resolvers->id, curr_resolvers->conf.file,
+				   curr_resolvers->conf.line);
+			err_code |= ERR_WARN;
+		}
+	}
+
 	list_for_each_entry(postparser, &postparsers, list) {
 		if (postparser->func)
 			cfgerr += postparser->func();