From: Bruce Momjian <bruce@momjian.us>
Date: Thu, 19 Dec 2019 15:33:48 +0000 (-0500)
Subject: Remove meaningless assignments in nbtree code
X-Git-Tag: REL_13_BETA1~993
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=05684c8255;p=thirdparty%2Fpostgresql.git

Remove meaningless assignments in nbtree code

Reported-by: Ranier Vilela

Discussion: https://postgr.es/m/MN2PR18MB2927BB876D12A70FDBE8F35AE3450@MN2PR18MB2927.namprd18.prod.outlook.com

Backpatch-through: master
---

diff --git a/src/backend/access/nbtree/nbtpage.c b/src/backend/access/nbtree/nbtpage.c
index e1a111b1ed4..4f10ede69d1 100644
--- a/src/backend/access/nbtree/nbtpage.c
+++ b/src/backend/access/nbtree/nbtpage.c
@@ -1600,7 +1600,6 @@ _bt_mark_page_halfdead(Relation rel, Buffer leafbuf, BTStack stack)
 	 * fail in the field, though.
 	 */
 	page = BufferGetPage(topparent);
-	opaque = (BTPageOpaque) PageGetSpecialPointer(page);
 
 #ifdef USE_ASSERT_CHECKING
 	itemid = PageGetItemId(page, topoff);
diff --git a/src/backend/access/nbtree/nbtxlog.c b/src/backend/access/nbtree/nbtxlog.c
index 4325cbee5ba..15be50642f1 100644
--- a/src/backend/access/nbtree/nbtxlog.c
+++ b/src/backend/access/nbtree/nbtxlog.c
@@ -590,8 +590,6 @@ btree_xlog_mark_page_halfdead(uint8 info, XLogReaderState *record)
 		BlockNumber rightsib;
 
 		page = (Page) BufferGetPage(buffer);
-		pageop = (BTPageOpaque) PageGetSpecialPointer(page);
-
 		poffset = xlrec->poffset;
 
 		nextoffset = OffsetNumberNext(poffset);