From: Krzysztof Kozlowski <krzk@kernel.org>
Date: Thu, 1 Mar 2018 20:50:10 +0000 (+0100)
Subject: crypto: omap-sham - Remove useless check for non-null request
X-Git-Tag: v4.17-rc1~128^2~69
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=05a02578e51b899b3a4202d58ea27ae45abe6fd7;p=thirdparty%2Flinux.git

crypto: omap-sham - Remove useless check for non-null request

ahash_request 'req' argument passed by the caller
omap_sham_handle_queue() cannot be NULL here because it is obtained from
non-NULL pointer via container_of().

This fixes smatch warning:
    drivers/crypto/omap-sham.c:812 omap_sham_prepare_request() warn: variable dereferenced before check 'req' (see line 805)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 8e7e1582ef695..fd380a7da4ebf 100644
--- a/drivers/crypto/omap-sham.c
+++ b/drivers/crypto/omap-sham.c
@@ -817,9 +817,6 @@ static int omap_sham_prepare_request(struct ahash_request *req, bool update)
 	bool final = rctx->flags & BIT(FLAGS_FINUP);
 	int xmit_len, hash_later;
 
-	if (!req)
-		return 0;
-
 	bs = get_block_size(rctx);
 
 	if (update)