From: Daniel Fiala <daniel@openssl.org>
Date: Tue, 28 Jun 2022 08:00:29 +0000 (+0200)
Subject: Remove redundant check for `saltlen > UINT32_MAX`
X-Git-Tag: openssl-3.2.0-alpha1~2455
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=05e51bc79bac45e194dd6f0bf73c99ed5ca06272;p=thirdparty%2Fopenssl.git

Remove redundant check for `saltlen > UINT32_MAX`

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18671)
---

diff --git a/providers/common/der/der_rsa_key.c b/providers/common/der/der_rsa_key.c
index 2ae53a171db..893970575f9 100644
--- a/providers/common/der/der_rsa_key.c
+++ b/providers/common/der/der_rsa_key.c
@@ -305,7 +305,7 @@ int ossl_DER_w_RSASSA_PSS_params(WPACKET *pkt, int tag,
     saltlen = ossl_rsa_pss_params_30_saltlen(pss);
     trailerfield = ossl_rsa_pss_params_30_trailerfield(pss);
 
-    if (saltlen < 0 || (unsigned int)saltlen > UINT32_MAX) {
+    if (saltlen < 0) {
         ERR_raise(ERR_LIB_RSA, RSA_R_INVALID_SALT_LENGTH);
         return 0;
     }