From: Hongbo Li Date: Wed, 25 Sep 2024 01:56:24 +0000 (+0800) Subject: fs: support relative paths with FSCONFIG_SET_STRING X-Git-Tag: v6.13-rc1~229^2~24 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=05fba0a11557dfdc1b6895f4a3fb59165669e643;p=thirdparty%2Fkernel%2Flinux.git fs: support relative paths with FSCONFIG_SET_STRING The fs_lookup_param did not consider the relative path for block device. When we mount ext4 with journal_path option using relative path, param->dirfd was not set which will cause mounting error. This can be reproduced easily like this: mke2fs -F -O journal_dev $JOURNAL_DEV -b 4096 100M mkfs.ext4 -F -J device=$JOURNAL_DEV -b 4096 $FS_DEV cd /dev; mount -t ext4 -o journal_path=`basename $JOURNAL_DEV` $FS_DEV $MNT Fixes: 461c3af045d3 ("ext4: Change handle_mount_opt() to use fs_parameter") Suggested-by: Christian Brauner Signed-off-by: Hongbo Li Link: https://lore.kernel.org/r/20240925015624.3817878-1-lihongbo22@huawei.com Signed-off-by: Christian Brauner --- diff --git a/fs/fs_parser.c b/fs/fs_parser.c index 24727ec34e5aa..698464f3e26a8 100644 --- a/fs/fs_parser.c +++ b/fs/fs_parser.c @@ -156,6 +156,7 @@ int fs_lookup_param(struct fs_context *fc, f = getname_kernel(param->string); if (IS_ERR(f)) return PTR_ERR(f); + param->dirfd = AT_FDCWD; put_f = true; break; case fs_value_is_filename: