From: Lulu Cai <cailulu@loongson.cn>
Date: Thu, 21 Mar 2024 07:16:05 +0000 (+0800)
Subject: LoongArch: ld:Report an error when seeing an unrecognized relocation
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=060bfd90813b829e7c6a8f7347d5f834d406c29b;p=thirdparty%2Fbinutils-gdb.git

LoongArch: ld:Report an error when seeing an unrecognized relocation

If we generate an object file using an assembler with the new
relocations added, and then linking those files with an older
linker, the link will still complete and the linked file will
be generated.
In this case we should report an error instead of continuing
the linking process.

(cherry picked from commit 5966e2eb3fed61ebe5c091a074b368b9238a68c1)
---

diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
index b0f9b6ec69e..25c0ac98874 100644
--- a/bfd/elfnn-loongarch.c
+++ b/bfd/elfnn-loongarch.c
@@ -2304,9 +2304,14 @@ loongarch_elf_relocate_section (bfd *output_bfd, struct bfd_link_info *info,
       bfd_vma relocation, off, ie_off;
       int i, j;
 
+      /* When an unrecognized relocation is encountered, which usually
+	 occurs when using a newer assembler but an older linker, an error
+	 should be reported instead of continuing to the next relocation.  */
       howto = loongarch_elf_rtype_to_howto (input_bfd, r_type);
-      if (howto == NULL || r_type == R_LARCH_GNU_VTINHERIT
-	  || r_type == R_LARCH_GNU_VTENTRY)
+      if (howto == NULL)
+	return _bfd_unrecognized_reloc (input_bfd, input_section, r_type);
+
+      if (r_type == R_LARCH_GNU_VTINHERIT || r_type == R_LARCH_GNU_VTENTRY)
 	continue;
 
       /* This is a final link.  */