From: Marek Schimara <Marek.Schimara@bull.net>
Date: Fri, 17 Jun 2016 08:54:29 +0000 (+0200)
Subject: src/rrd_cgi.c: fix Coverity CID#13655 Resource leak
X-Git-Tag: v1.7.0~42^2~11
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=065c3e2b691ff1f6ed6e7fc5b6bb34b8fa88a11d;p=thirdparty%2Frrdtool-1.x.git

src/rrd_cgi.c: fix Coverity CID#13655 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html
---

diff --git a/src/rrd_cgi.c b/src/rrd_cgi.c
index 0b872aa8..7f6e20fc 100644
--- a/src/rrd_cgi.c
+++ b/src/rrd_cgi.c
@@ -1570,13 +1570,16 @@ s_cgi    *rrdcgiInit(
     s_cgi    *res;
     s_var   **vars;
 
+    if ((res = (s_cgi *) malloc(sizeof(s_cgi))) == NULL)
+        return NULL;
+
     vars = rrdcgiReadVariables();
 
-    if (!vars)
+    if (!vars) {
+    	free(res);
         return NULL;
+    }
 
-    if ((res = (s_cgi *) malloc(sizeof(s_cgi))) == NULL)
-        return NULL;
     res->vars = vars;
 
     return res;