From: Peiyang He <peiyang_he@smail.nju.edu.cn>
Date: Sun, 5 Jul 2026 11:14:09 +0000 (+0800)
Subject: ntfs: fix hole runlist memory leak in insert range error path
X-Git-Tag: v7.2-rc3~20^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=06769b8f23b4b645b270c438649fff79768fb6fe;p=thirdparty%2Fkernel%2Flinux.git

ntfs: fix hole runlist memory leak in insert range error path

ntfs_non_resident_attr_insert_range() allocates hole_rl before mapping the
whole runlist. If ntfs_attr_map_whole_runlist() fails, the error path drops
ni->runlist.lock and returns without freeing hole_rl. This leaks memory
of sizeof(*hole_rl) * 2 bytes.

Fix this memory leak by freeing hole_rl before returning from
that error path, matching the later error paths in the same function.

Fixes: 495e90fa3348 ("ntfs: update attrib operations")
Cc: stable@vger.kernel.org
Signed-off-by: Peiyang He <peiyang_he@smail.nju.edu.cn>
Reviewed-by: Hyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
---

diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
index e5e3bc03ad49..239b7bcbaedf 100644
--- a/fs/ntfs/attrib.c
+++ b/fs/ntfs/attrib.c
@@ -5328,6 +5328,7 @@ int ntfs_non_resident_attr_insert_range(struct ntfs_inode *ni, s64 start_vcn, s6
 	ret = ntfs_attr_map_whole_runlist(ni);
 	if (ret) {
 		up_write(&ni->runlist.lock);
+		kfree(hole_rl);
 		return ret;
 	}