From: Simon Marchi Date: Fri, 1 Dec 2023 16:27:33 +0000 (-0500) Subject: gdb: add missing raw register read in aarch64_sme_pseudo_register_write X-Git-Tag: binutils-2_42~582 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=06f02beb8fae22b079ed7c5360c17b3670cbb291;p=thirdparty%2Fbinutils-gdb.git gdb: add missing raw register read in aarch64_sme_pseudo_register_write It seems like the intention here is to read the contents of the ZA register and only write part of it. However, there's no actual read of the ZA register, so it looks like we'll write uninitialized bytes to the target, for the portion of the raw register where we don't write the pseudo register. Add a call to raw_read to fix this. I don't know how to test this though. Change-Id: I7548240bd4324f6a3b729a1ebf7502fae5a46e9e Reviewed-By: John Baldwin Approved-by: Luis Machado --- diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index 5c3b824ed0a..e3658c2c8e1 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -3337,6 +3337,7 @@ aarch64_sme_pseudo_register_write (struct gdbarch *gdbarch, /* Fetch the contents of ZA. */ size_t svl = sve_vl_from_vq (tdep->sme_svq); gdb::byte_vector za (std::pow (svl, 2)); + regcache->raw_read (tdep->sme_za_regnum, za); /* Copy the requested data. */ for (int chunks = 0; chunks < offsets.chunks; chunks++)