From: Phil Sutter <phil@nwl.cc>
Date: Thu, 17 Nov 2022 16:37:27 +0000 (+0100)
Subject: extensions: libebt_log: Add comment to clarify xlate callback
X-Git-Tag: v1.8.9~50
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=06f0d6fdb73be00570604b33c00b1f7bf1dacaa5;p=thirdparty%2Fiptables.git

extensions: libebt_log: Add comment to clarify xlate callback

Several log flags are ignored by the function. Add a comment explaining
why this is correct.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/extensions/libebt_log.c b/extensions/libebt_log.c
index 47708d79..13c7fafe 100644
--- a/extensions/libebt_log.c
+++ b/extensions/libebt_log.c
@@ -191,6 +191,8 @@ static int brlog_xlate(struct xt_xlate *xl,
 	if (loginfo->loglevel != LOG_DEFAULT_LEVEL)
 		xt_xlate_add(xl, " level %s", eight_priority[loginfo->loglevel].c_name);
 
+	/* ebt_log always decodes MAC header, nft_log always decodes upper header -
+	 * so set flags ether and ignore EBT_LOG_IP, EBT_LOG_ARP and EBT_LOG_IP6 */
 	xt_xlate_add(xl, " flags ether ");
 
 	return 1;