From: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Date: Wed, 3 Jun 2020 08:09:00 +0000 (+0800)
Subject: monitor/hmp-cmds: delete redundant Error check before invoke hmp_handle_error()
X-Git-Tag: v5.1.0-rc0~63^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0705ecc4ade74f03df00e8528987e7876a293f3b;p=thirdparty%2Fqemu.git

monitor/hmp-cmds: delete redundant Error check before invoke hmp_handle_error()

hmp_handle_error() does Error check internally.

Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Message-Id: <20200603080904.997083-6-maozhongyi@cmss.chinamobile.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---

diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index a704b3469ac..504796d6e9f 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -1637,9 +1637,8 @@ void hmp_object_add(Monitor *mon, const QDict *qdict)
     obj = user_creatable_add_opts(opts, &err);
     qemu_opts_del(opts);
 
-    if (err) {
-        hmp_handle_error(mon, err);
-    }
+    hmp_handle_error(mon, err);
+
     if (obj) {
         object_unref(obj);
     }