From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Mon, 13 Feb 2023 15:14:24 +0000 (+0100)
Subject: BUG/MINOR: quic: Wrong datagram dispatch because of qc_check_dcid()
X-Git-Tag: v2.8-dev4~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=07846cbda87f5f7c8e2324a333422fc9bbf048e6;p=thirdparty%2Fhaproxy.git

BUG/MINOR: quic: Wrong datagram dispatch because of qc_check_dcid()

There was a parenthesis placed in the wrong place for a memcmp().
As a consequence, clients could not reuse a UDP address for a new connection.

Must be backported to 2.7.
---

diff --git a/src/quic_conn.c b/src/quic_conn.c
index bf0581cfc1..a73f7c0575 100644
--- a/src/quic_conn.c
+++ b/src/quic_conn.c
@@ -7542,7 +7542,7 @@ int qc_check_dcid(struct quic_conn *qc, unsigned char *dcid, size_t dcid_len)
 	if ((qc->scid.len == dcid_len &&
 	     memcmp(qc->scid.data, dcid, dcid_len) == 0) ||
 	    (qc->odcid.len == dcid_len &&
-	     memcmp(qc->odcid.data, dcid, dcid_len)) == 0) {
+	     memcmp(qc->odcid.data, dcid, dcid_len) == 0)) {
 		return 1;
 	}