From: Miroslav Lichvar <mlichvar@redhat.com>
Date: Wed, 24 Sep 2014 13:13:03 +0000 (+0200)
Subject: util: optimize UTI_RefidToString()
X-Git-Tag: 2.0-pre1~92
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=078f0f511e59b47fb772588b240e3f6e943659ba;p=thirdparty%2Fchrony.git

util: optimize UTI_RefidToString()
---

diff --git a/util.c b/util.c
index aedf2c92..7a39ffbb 100644
--- a/util.c
+++ b/util.c
@@ -238,18 +238,18 @@ char *
 UTI_RefidToString(uint32_t ref_id)
 {
   unsigned int i, j, c;
-  char buf[5], *result;
+  char *result;
+
+  result = NEXT_BUFFER;
 
-  for (i = j = 0; i < 4; i++) {
+  for (i = j = 0; i < 4 && i < BUFFER_LENGTH - 1; i++) {
     c = (ref_id >> (24 - i * 8)) & 0xff;
     if (isprint(c))
-      buf[j++] = c;
+      result[j++] = c;
   }
 
-  buf[j] = '\0';
+  result[j] = '\0';
 
-  result = NEXT_BUFFER;
-  snprintf(result, BUFFER_LENGTH, "%s", buf);
   return result;
 }