From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 2 Feb 2021 15:06:39 +0000 (+0100)
Subject: rec: Add comment about moving the aggressive NSEC cache check
X-Git-Tag: dnsdist-1.6.0-alpha2~12^2~15
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=07ba58ec94fe869547b7e2e38fd5238c82cd8762;p=thirdparty%2Fpdns.git

rec: Add comment about moving the aggressive NSEC cache check
---

diff --git a/pdns/syncres.cc b/pdns/syncres.cc
index 4170a1a2e7..8e658c1d3d 100644
--- a/pdns/syncres.cc
+++ b/pdns/syncres.cc
@@ -1036,7 +1036,9 @@ int SyncRes::doResolveNoQNameMinimization(const DNSName &qname, const QType qtyp
 
   LOG(prefix<<qname<<": initial validation status for "<<qname<<" is "<<state<<endl);
 
-  #warning move aggressive NSEC check here? We know more about the zone and its status by now..
+  // XXX: We could move aggressive NSEC check here? We know more about the zone and its status by now,
+  // but on the other hand it means we have already done the zone cut determination which is not good
+  // Perhaps delay that change until after the DNSSEC zone cut refactoring?
 
   res = doResolveAt(nsset, subdomain, flawedNSSet, qname, qtype, ret, depth, beenthere, state, stopAtDelegation);