From: Jakub Kicinski <kuba@kernel.org>
Date: Thu, 3 Apr 2025 01:37:03 +0000 (-0700)
Subject: netlink: specs: rt_addr: fix the spec format / schema failures
X-Git-Tag: v6.15-rc1~19^2~1^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0802c32d4b03a26604c2db2c8a63b34a80361305;p=thirdparty%2Flinux.git

netlink: specs: rt_addr: fix the spec format / schema failures

The spec is mis-formatted, schema validation says:

  Failed validating 'type' in schema['properties']['operations']['properties']['list']['items']['properties']['dump']['properties']['request']['properties']['value']:
    {'minimum': 0, 'type': 'integer'}

  On instance['operations']['list'][3]['dump']['request']['value']:
    '58 - ifa-family'

The ifa-family clearly wants to be part of an attribute list.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Reviewed-by: Yuyang Huang <yuyanghuang@google.com>
Fixes: 4f280376e531 ("selftests/net: Add selftest for IPv4 RTM_GETMULTICAST support")
Link: https://patch.msgid.link/20250403013706.2828322-2-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/Documentation/netlink/specs/rt_addr.yaml b/Documentation/netlink/specs/rt_addr.yaml
index 5dd5469044c79..3bc9b6f9087e9 100644
--- a/Documentation/netlink/specs/rt_addr.yaml
+++ b/Documentation/netlink/specs/rt_addr.yaml
@@ -187,6 +187,7 @@ operations:
       dump:
         request:
           value: 58
+          attributes:
             - ifa-family
         reply:
           value: 58