From: Jeff King <peff@peff.net>
Date: Thu, 8 Sep 2022 19:24:21 +0000 (-0400)
Subject: fetch: stop checking for NULL transport->remote in do_fetch()
X-Git-Tag: v2.38.0-rc0~1^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=080bc4990f56f9d0687919e5136cb138509f1269;p=thirdparty%2Fgit.git

fetch: stop checking for NULL transport->remote in do_fetch()

This field will never be NULL; if it were, we'd segfault earlier in the
function when we unconditionally check transport->remote->fetch_tags.
Likewise, many other functions dereference it unconditionally.

This is a small simplification, but it will make things easier as we
extend this conditional in the next patch.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/fetch.c b/builtin/fetch.c
index ac29c2b1ae..d39098d9ab 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -1626,7 +1626,7 @@ static int do_fetch(struct transport *transport,
 				break;
 			}
 		}
-	} else if (transport->remote && transport->remote->fetch.nr)
+	} else if (transport->remote->fetch.nr)
 		refspec_ref_prefixes(&transport->remote->fetch,
 				     &transport_ls_refs_options.ref_prefixes);