From: Vsevolod Stakhov <vsevolod@highsecure.ru>
Date: Fri, 17 Sep 2021 20:36:32 +0000 (+0100)
Subject: [Minor] Remove dead loop
X-Git-Tag: 3.1~152
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0832f067cbba7812e166f857326c8f83d220692a;p=thirdparty%2Frspamd.git

[Minor] Remove dead loop
---

diff --git a/src/libserver/rspamd_symcache.c b/src/libserver/rspamd_symcache.c
index bd8a5bb910..41aa784b6a 100644
--- a/src/libserver/rspamd_symcache.c
+++ b/src/libserver/rspamd_symcache.c
@@ -952,21 +952,17 @@ rspamd_symcache_save_items (struct rspamd_symcache *cache, const gchar *name)
 
 	rspamd_snprintf (path, sizeof (path), "%s.new", name);
 
-	for (;;) {
-		fd = open (path, O_CREAT | O_WRONLY | O_EXCL, 00644);
+	fd = open (path, O_CREAT | O_WRONLY | O_EXCL, 00644);
 
-		if (fd == -1) {
-			if (errno == EEXIST) {
-				/* Some other process is already writing data, give up silently */
-				return TRUE;
-			}
-
-			msg_err_cache ("cannot open file %s, error %d, %s", path,
-					errno, strerror (errno));
-			return FALSE;
+	if (fd == -1) {
+		if (errno == EEXIST) {
+			/* Some other process is already writing data, give up silently */
+			return TRUE;
 		}
 
-		break;
+		msg_err_cache ("cannot open file %s, error %d, %s", path,
+				errno, strerror (errno));
+		return FALSE;
 	}
 
 	rspamd_file_lock (fd, FALSE);