From: Richard Biener <rguenther@suse.de>
Date: Wed, 24 Feb 2021 08:18:05 +0000 (+0100)
Subject: c/99224 - avoid ICEing on invalid __builtin_next_arg
X-Git-Tag: basepoints/gcc-12~904
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=084963dcaca2f0836366fdb001561e29ecbfb483;p=thirdparty%2Fgcc.git

c/99224 - avoid ICEing on invalid __builtin_next_arg

This avoids crashes with __builtin_next_arg on non-parameters.  For
the specific testcase we arrive with an anonymous SSA_NAME so that
SSA_NAME_VAR becomes NULL and we crash.

2021-02-24  Richard Biener  <rguenther@suse.de>

	PR c/99224
	* builtins.c (fold_builtin_next_arg): Avoid NULL arg.

	* gcc.dg/pr99224.c: New testcase.
---

diff --git a/gcc/builtins.c b/gcc/builtins.c
index 0aed008687cc..42150cee0bd2 100644
--- a/gcc/builtins.c
+++ b/gcc/builtins.c
@@ -12597,7 +12597,8 @@ fold_builtin_next_arg (tree exp, bool va_start_p)
       arg = CALL_EXPR_ARG (exp, 0);
     }
 
-  if (TREE_CODE (arg) == SSA_NAME)
+  if (TREE_CODE (arg) == SSA_NAME
+      && SSA_NAME_VAR (arg))
     arg = SSA_NAME_VAR (arg);
 
   /* We destructively modify the call to be __builtin_va_start (ap, 0)
diff --git a/gcc/testsuite/gcc.dg/pr99224.c b/gcc/testsuite/gcc.dg/pr99224.c
new file mode 100644
index 000000000000..f6e9ac8eba3c
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr99224.c
@@ -0,0 +1,6 @@
+/* { dg-do compile } */
+
+void f (char *c, ...)
+{
+  __builtin_next_arg (*c); /* { dg-warning "not last named argument" } */
+}