From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Mon, 16 May 2016 13:55:34 +0000 (+0300)
Subject: lib-compression: Changed impossible errors to asserts.
X-Git-Tag: 2.3.0.rc1~3724
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=08ab0b21d9da8881280071016a4475ee95f16c17;p=thirdparty%2Fdovecot%2Fcore.git

lib-compression: Changed impossible errors to asserts.

o_stream_flush() no longer calls the stream's flush() if stream has failed.
---

diff --git a/src/lib-compression/ostream-bzlib.c b/src/lib-compression/ostream-bzlib.c
index 4e9cf2ec67..ed6e797f89 100644
--- a/src/lib-compression/ostream-bzlib.c
+++ b/src/lib-compression/ostream-bzlib.c
@@ -103,12 +103,7 @@ static int o_stream_bzlib_send_flush(struct bzlib_ostream *zstream)
 	bool done = FALSE;
 	int ret;
 
-	if (zs->avail_in != 0) {
-		i_assert(zstream->ostream.ostream.last_failed_errno != 0);
-		zstream->ostream.ostream.stream_errno =
-			zstream->ostream.ostream.last_failed_errno;
-		return -1;
-	}
+	i_assert(zs->avail_in == 0);
 
 	if (zstream->flushed)
 		return 0;
diff --git a/src/lib-compression/ostream-lzma.c b/src/lib-compression/ostream-lzma.c
index 4fcd04e8be..5000d5da69 100644
--- a/src/lib-compression/ostream-lzma.c
+++ b/src/lib-compression/ostream-lzma.c
@@ -109,12 +109,7 @@ static int o_stream_lzma_send_flush(struct lzma_ostream *zstream)
 	bool done = FALSE;
 	int ret;
 
-	if (zs->avail_in != 0) {
-		i_assert(zstream->ostream.ostream.last_failed_errno != 0);
-		zstream->ostream.ostream.stream_errno =
-			zstream->ostream.ostream.last_failed_errno;
-		return -1;
-	}
+	i_assert(zs->avail_in == 0);
 
 	if (zstream->flushed)
 		return 0;
diff --git a/src/lib-compression/ostream-zlib.c b/src/lib-compression/ostream-zlib.c
index 134cbff7cc..d043e4bdbf 100644
--- a/src/lib-compression/ostream-zlib.c
+++ b/src/lib-compression/ostream-zlib.c
@@ -172,12 +172,7 @@ o_stream_zlib_send_flush(struct zlib_ostream *zstream, bool final)
 	bool done = FALSE;
 	int ret, flush;
 
-	if (zs->avail_in != 0) {
-		i_assert(zstream->ostream.ostream.last_failed_errno != 0);
-		zstream->ostream.ostream.stream_errno =
-			zstream->ostream.ostream.last_failed_errno;
-		return -1;
-	}
+	i_assert(zs->avail_in == 0);
 
 	if (zstream->flushed)
 		return 0;