From: Yang Li Date: Fri, 31 Mar 2023 01:06:33 +0000 (+0800) Subject: RDMA/cma: Remove NULL check before dev_{put, hold} X-Git-Tag: v6.4-rc1~75^2~33 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=08ebf57f6e1d73cc1890e1ff1b1c74887c53770b;p=thirdparty%2Fkernel%2Flinux.git RDMA/cma: Remove NULL check before dev_{put, hold} The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warnings: ./drivers/infiniband/core/cma.c:713:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed. ./drivers/infiniband/core/cma.c:2433:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4668 Signed-off-by: Yang Li Link: https://lore.kernel.org/r/20230331010633.63261-1-yang.lee@linux.alibaba.com Signed-off-by: Leon Romanovsky --- diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index 3081559377133..9c7d26a7d2435 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c @@ -710,8 +710,7 @@ cma_validate_port(struct ib_device *device, u32 port, } sgid_attr = rdma_find_gid_by_port(device, gid, gid_type, port, ndev); - if (ndev) - dev_put(ndev); + dev_put(ndev); return sgid_attr; } @@ -2430,8 +2429,7 @@ err_unlock: mutex_unlock(&listen_id->handler_mutex); net_dev_put: - if (net_dev) - dev_put(net_dev); + dev_put(net_dev); return ret; }