From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Mon, 21 Nov 2022 10:38:54 +0000 (+0100)
Subject: Infra queries should not use refresh mode.
X-Git-Tag: rec-4.8.0~1^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=09022ecbdb061c8cd7c66e1587b5d8aa541d8c78;p=thirdparty%2Fpdns.git

Infra queries should not use refresh mode.

When I introduced serve state in #11776, I reintroduced the mistake previously fixed in #11376.
Fixes #12078

(cherry picked from commit 28a3eea55d15d33a65b2108c1598c15d00e0173c)
---

diff --git a/pdns/syncres.cc b/pdns/syncres.cc
index cd018408f6..006095d83d 100644
--- a/pdns/syncres.cc
+++ b/pdns/syncres.cc
@@ -2073,9 +2073,6 @@ vector<ComboAddress> SyncRes::getAddrs(const DNSName &qname, unsigned int depth,
   if (d_serveStale) {
     flags |= MemRecursorCache::ServeStale;
   }
-  if (d_refresh) {
-    flags |= MemRecursorCache::Refresh;
-  }
   try {
     // First look for both A and AAAA in the cache
     res_t cset;
@@ -2223,9 +2220,6 @@ void SyncRes::getBestNSFromCache(const DNSName &qname, const QType qtype, vector
   if (d_serveStale) {
     flags |= MemRecursorCache::ServeStale;
   }
-  if (d_refresh) {
-    flags |= MemRecursorCache::Refresh;
-  }
   do {
     if (cutOffDomain && (subdomain == *cutOffDomain || !subdomain.isPartOf(*cutOffDomain))) {
       break;