From: Miklos Szeredi Date: Thu, 2 May 2024 18:35:57 +0000 (+0200) Subject: ovl: remove upper umask handling from ovl_create_upper() X-Git-Tag: v6.10-rc1~55^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=096802748ea1dea8b476938e0a8dc16f4bd2f1ad;p=thirdparty%2Fkernel%2Flinux.git ovl: remove upper umask handling from ovl_create_upper() This is already done by vfs_prepare_mode() when creating the upper object by vfs_create(), vfs_mkdir() and vfs_mknod(). No regressions have been observed in xfstests run with posix acls turned off for the upper filesystem. Fixes: 1639a49ccdce ("fs: move S_ISGID stripping into the vfs_*() helpers") Signed-off-by: Miklos Szeredi --- diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c index c614e923b1434..116f542442ddd 100644 --- a/fs/overlayfs/dir.c +++ b/fs/overlayfs/dir.c @@ -330,9 +330,6 @@ static int ovl_create_upper(struct dentry *dentry, struct inode *inode, struct dentry *newdentry; int err; - if (!attr->hardlink && !IS_POSIXACL(udir)) - attr->mode &= ~current_umask(); - inode_lock_nested(udir, I_MUTEX_PARENT); newdentry = ovl_create_real(ofs, udir, ovl_lookup_upper(ofs, dentry->d_name.name,