From: Andrew Lunn <andrew@lunn.ch>
Date: Mon, 21 Nov 2016 22:26:56 +0000 (+0100)
Subject: net: dsa: mv88e6xxx: Fix unused variable warning by using variable
X-Git-Tag: v4.10-rc1~202^2~204^2~9
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=096eea0ff83bcdd14d77fb4efc0ffc2b548d4a5d;p=thirdparty%2Fkernel%2Flinux.git

net: dsa: mv88e6xxx: Fix unused variable warning by using variable

_mv88e6xxx_stats_wait() did not check the return value from
 mv88e6xxx_g1_read(), so the compiler complained about set but unused
 err.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 062b9128a58d7..c0152125680f0 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -787,6 +787,9 @@ static int _mv88e6xxx_stats_wait(struct mv88e6xxx_chip *chip)
 
 	for (i = 0; i < 10; i++) {
 		err = mv88e6xxx_g1_read(chip, GLOBAL_STATS_OP, &val);
+		if (err)
+			return err;
+
 		if ((val & GLOBAL_STATS_OP_BUSY) == 0)
 			return 0;
 	}