From: Michael Tremer <michael.tremer@ipfire.org>
Date: Mon, 17 Mar 2025 11:22:16 +0000 (+0000)
Subject: jail: Fix return code of nice function
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0976a6a5b2de75562dcfc3304d56c34a5a8eb5c3;p=pakfire.git

jail: Fix return code of nice function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/pakfire/jail.c b/src/pakfire/jail.c
index c3951249..92c22c22 100644
--- a/src/pakfire/jail.c
+++ b/src/pakfire/jail.c
@@ -267,10 +267,8 @@ struct pakfire_jail* pakfire_jail_unref(struct pakfire_jail* jail) {
 
 int pakfire_jail_nice(struct pakfire_jail* jail, int nice) {
 	// Check if nice level is in range
-	if (nice < -19 || nice > 20) {
-		errno = EINVAL;
-		return 1;
-	}
+	if (nice < -19 || nice > 20)
+		return -EINVAL;
 
 	// Store nice level
 	jail->nice = nice;
diff --git a/tests/libpakfire/jail.c b/tests/libpakfire/jail.c
index 2e29670c..1d22abb9 100644
--- a/tests/libpakfire/jail.c
+++ b/tests/libpakfire/jail.c
@@ -176,8 +176,8 @@ static int test_nice(const struct test* t) {
 	ASSERT_SUCCESS(pakfire_jail_create(&jail, t->pakfire));
 
 	// Set invalid nice levels
-	ASSERT_ERRNO(pakfire_jail_nice(jail,  100), EINVAL);
-	ASSERT_ERRNO(pakfire_jail_nice(jail, -100), EINVAL);
+	ASSERT_ERROR(pakfire_jail_nice(jail,  100), EINVAL);
+	ASSERT_ERROR(pakfire_jail_nice(jail, -100), EINVAL);
 
 	// Set something sane
 	ASSERT_SUCCESS(pakfire_jail_nice(jail, 5));