From: Miod Vallat <miod.vallat@powerdns.com>
Date: Fri, 5 Sep 2025 06:00:42 +0000 (+0200)
Subject: Address some coverity-reported warnings.
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=09aea86f01734bb8f99d03a5a6c4b0dcfe7dca6a;p=thirdparty%2Fpdns.git

Address some coverity-reported warnings.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/pdns/pdnsutil.cc b/pdns/pdnsutil.cc
index 06aa5322e..162c294fd 100644
--- a/pdns/pdnsutil.cc
+++ b/pdns/pdnsutil.cc
@@ -1963,7 +1963,7 @@ static bool parseZoneFile(const char* tmpnam, int& errorline, std::vector<DNSRec
   try {
     while(zpt.get(zrr)) {
       DNSRecord rec(zrr);
-      records.push_back(rec);
+      records.push_back(std::move(rec));
     }
   }
   catch(std::exception& e) {
@@ -2078,7 +2078,9 @@ static int editZone(const ZoneName &zone, const PDNSColors& col)
   }
 
   // Get the original SOA record once, for comparison purposes.
-  B.getSOAUncached(info.zone, soa);
+  // Note that this may fail if there is no active SOA record, which is not a
+  // problem here, as we are only interested into the _current_ serial number.
+  (void)B.getSOAUncached(info.zone, soa);
 
   // Ensure that the temporary file will only be accessible by the current user,
   // not even by other users in the same group, and certainly not by other