From: Francis Dupont Date: Mon, 15 Sep 2025 19:43:37 +0000 (+0200) Subject: [#4094] Addressed some comments X-Git-Tag: Kea-3.1.2~23 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=09bc23548ee0b8d0d1cc7de9ebf1ce48f479be0e;p=thirdparty%2Fkea.git [#4094] Addressed some comments --- diff --git a/doc/sphinx/api-files.txt b/doc/sphinx/api-files.txt index 7871938f92..32cd2438af 100644 --- a/doc/sphinx/api-files.txt +++ b/doc/sphinx/api-files.txt @@ -43,6 +43,7 @@ src/share/api/ha-reset.json src/share/api/ha-scopes.json src/share/api/ha-sync.json src/share/api/ha-sync-complete-notify.json +src/share/api/kea-lfc-start.json src/share/api/lease4-add.json src/share/api/lease4-del.json src/share/api/lease4-get.json diff --git a/doc/sphinx/arm/ctrl-channel.rst b/doc/sphinx/arm/ctrl-channel.rst index 3405fd2788..1c330114f8 100644 --- a/doc/sphinx/arm/ctrl-channel.rst +++ b/doc/sphinx/arm/ctrl-channel.rst @@ -896,8 +896,8 @@ command-line argument. This command does not take any parameters. The ``kea-lfc-start`` Command ----------------------------- -The isccmd:`kea-lfc-start` command starts the ``kea-lfc`` process which -cleans up the lease file (see :ref:`kea-lfc`). It takes no argument and +The :isccmd:`kea-lfc-start` command starts the ``kea-lfc`` process which +cleans up the lease file (see :ref:`kea-lfc`). It takes no arguments and returns an error when the lease backend is not the ``memfile`` or when the ``persist`` parameter of the ``lease-database`` was configured to ``false`` (but not when ``lfc-interval`` is ``0``). diff --git a/src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc b/src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc index ebbe515418..cb6018874f 100644 --- a/src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc +++ b/src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc @@ -4661,10 +4661,10 @@ TEST_F(MemfileLeaseMgrLogTest, lfcStartHandlerPersistFalse) { /// @brief Verifies that lfcStartHandler does not requires lfc-interval > 0. TEST_F(MemfileLeaseMgrLogTest, lfcStartHandlerLfcInterval0) { DatabaseConnection::ParameterMap pmap; - pmap["universe"] = "4"; + pmap["universe"] = "6"; pmap["persist"] = "true"; pmap["lfc-interval"] = "0"; - pmap["name"] = getLeaseFilePath("leasefile4_0.csv"); + pmap["name"] = getLeaseFilePath("leasefile6_0.csv"); boost::scoped_ptr lease_mgr; // Persist is false so there is no lease file... diff --git a/src/share/api/kea-lfc-start.json b/src/share/api/kea-lfc-start.json index 356b187f91..749aa6a574 100644 --- a/src/share/api/kea-lfc-start.json +++ b/src/share/api/kea-lfc-start.json @@ -2,7 +2,7 @@ "access": "write", "avail": "3.1.2", "brief": [ - "This command starts the kea-lfc process which cleas nup the lease file. ", + "This command starts the kea-lfc process which cleans up the lease file. ", "This command does not take any parameters." ], "cmd-syntax": [