From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Fri, 14 Mar 2025 22:20:45 +0000 (+0900)
Subject: test: fix wrong use of ASSERT_OK() and friends
X-Git-Tag: v258-rc1~1075^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=09e0ce8010d5fd10db1c44c493d4700e27b0f8f0;p=thirdparty%2Fsystemd.git

test: fix wrong use of ASSERT_OK() and friends
---

diff --git a/src/libsystemd/sd-device/test-sd-device.c b/src/libsystemd/sd-device/test-sd-device.c
index b2b04562cde..e9d24570daa 100644
--- a/src/libsystemd/sd-device/test-sd-device.c
+++ b/src/libsystemd/sd-device/test-sd-device.c
@@ -544,7 +544,7 @@ TEST(sd_device_enumerator_add_all_parents) {
         log_debug("found %u devices", devices_count_without_parents);
 
         /* STEP 2: enumerate again with all_parents() */
-        ASSERT_OK(sd_device_enumerator_add_all_parents(e) >= 0);
+        ASSERT_OK(sd_device_enumerator_add_all_parents(e));
 
         unsigned not_filtered_parent_count = 0;
         FOREACH_DEVICE(e, dev) {
diff --git a/src/test/test-id128.c b/src/test/test-id128.c
index 4ff95deaea7..48af629b73d 100644
--- a/src/test/test-id128.c
+++ b/src/test/test-id128.c
@@ -31,7 +31,7 @@ TEST(id128) {
         ASSERT_OK(sd_id128_randomize(&id));
         printf("random: %s\n", sd_id128_to_string(id, t));
 
-        ASSERT_OK(sd_id128_from_string(t, &id2) == 0);
+        ASSERT_OK(sd_id128_from_string(t, &id2));
         ASSERT_EQ_ID128(id, id2);
         ASSERT_TRUE(sd_id128_in_set(id, id));
         ASSERT_TRUE(sd_id128_in_set(id, id2));
@@ -116,7 +116,7 @@ TEST(id128) {
         ASSERT_OK(sd_id128_randomize(&id));
         ASSERT_OK(id128_write_fd(fd, ID128_FORMAT_PLAIN, id));
 
-        ASSERT_OK_ERRNO(lseek(fd, 0, SEEK_SET) == 0);
+        ASSERT_OK_ERRNO(lseek(fd, 0, SEEK_SET));
         ASSERT_ERROR(id128_read_fd(fd, ID128_FORMAT_UUID, &id2), EUCLEAN);
 
         ASSERT_OK_ERRNO(lseek(fd, 0, SEEK_SET));