From: Chen Ni Date: Tue, 25 Mar 2025 08:46:39 +0000 (+0800) Subject: ALSA: hda: cs35l56: Remove unnecessary NULL check before release_firmware() X-Git-Tag: v6.15-rc1~173^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=09e269f550f548a1249ba5282747fe67ba177608;p=thirdparty%2Flinux.git ALSA: hda: cs35l56: Remove unnecessary NULL check before release_firmware() release_firmware() checks for NULL pointers internally. Remove unneeded NULL check for fmw here. Signed-off-by: Chen Ni Link: https://patch.msgid.link/20250325084639.801054-1-nichen@iscas.ac.cn Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c index 4ef7878e8fd4b..235d22049aa9f 100644 --- a/sound/pci/hda/cs35l56_hda.c +++ b/sound/pci/hda/cs35l56_hda.c @@ -546,12 +546,10 @@ static void cs35l56_hda_release_firmware_files(const struct firmware *wmfw_firmw const struct firmware *coeff_firmware, char *coeff_filename) { - if (wmfw_firmware) - release_firmware(wmfw_firmware); + release_firmware(wmfw_firmware); kfree(wmfw_filename); - if (coeff_firmware) - release_firmware(coeff_firmware); + release_firmware(coeff_firmware); kfree(coeff_filename); }