From: SZEDER Gábor Date: Sun, 24 Aug 2025 19:06:44 +0000 (+0200) Subject: line-log: simplify condition checking for merge commits X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0a15bb634cf005a0266ee1108ac31aa75649a61c;p=thirdparty%2Fgit.git line-log: simplify condition checking for merge commits In process_ranges_arbitrary_commit() the condition deciding whether the given commit is not a merge, i.e. that it doesn't have more than one parent, is head-scratchingly backwards, flip it. Signed-off-by: SZEDER Gábor Signed-off-by: Junio C Hamano --- diff --git a/line-log.c b/line-log.c index 71fa857ee8..188d387d40 100644 --- a/line-log.c +++ b/line-log.c @@ -1273,10 +1273,10 @@ int line_log_process_ranges_arbitrary_commit(struct rev_info *rev, struct commit struct line_log_data *prange = line_log_data_copy(range); add_line_range(rev, commit->parents->item, prange); clear_commit_line_range(rev, commit); - } else if (!commit->parents || !commit->parents->next) - changed = process_ranges_ordinary_commit(rev, commit, range); - else + } else if (commit->parents && commit->parents->next) changed = process_ranges_merge_commit(rev, commit, range); + else + changed = process_ranges_ordinary_commit(rev, commit, range); } if (!changed)