From: Sascha Hauer Date: Mon, 16 Jun 2025 13:45:03 +0000 (+0200) Subject: gpio: pca953x: fix wrong error probe return value X-Git-Tag: v6.16-rc3~18^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0a1db19f66c0960eb00e1f2ccd40708b6747f5b1;p=thirdparty%2Fkernel%2Flinux.git gpio: pca953x: fix wrong error probe return value The second argument to dev_err_probe() is the error value. Pass the return value of devm_request_threaded_irq() there instead of the irq number. Signed-off-by: Sascha Hauer Fixes: c47f7ff0fe61 ("gpio: pca953x: Utilise dev_err_probe() where it makes sense") Link: https://lore.kernel.org/r/20250616134503.1201138-1-s.hauer@pengutronix.de Signed-off-by: Bartosz Golaszewski --- diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index b852e49976294..e80a96f397885 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -974,7 +974,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base) IRQF_ONESHOT | IRQF_SHARED, dev_name(dev), chip); if (ret) - return dev_err_probe(dev, client->irq, "failed to request irq\n"); + return dev_err_probe(dev, ret, "failed to request irq\n"); return 0; }