From: Aaron Merey <amerey@redhat.com>
Date: Sat, 25 Jan 2025 01:21:57 +0000 (-0500)
Subject: src/readelf.c: Close skel_fd
X-Git-Tag: elfutils-0.193~57
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0a33efadcd2df8afad97359d2354d319612741dd;p=thirdparty%2Felfutils.git

src/readelf.c: Close skel_fd

skel_fd is passed to create_dwfl, which calls dup() on skel_fd.
create_dwfl handles closing the duped fd but not the original.

Ensure the original skel_fd is closed after it's passed to create_dwfl.

Signed-off-by: Aaron Merey <amerey@redhat.com>
---

diff --git a/src/readelf.c b/src/readelf.c
index 3e97b64c..6526db07 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -11921,7 +11921,13 @@ print_debug (Dwfl_Module *dwflmod, Ebl *ebl, GElf_Ehdr *ehdr)
 		fprintf (stderr, "Warning: Couldn't open DWARF skeleton file"
 			 " '%s'\n", skel_name);
 	      else
-		skel_dwfl = create_dwfl (skel_fd, skel_name);
+		{
+		  skel_dwfl = create_dwfl (skel_fd, skel_name);
+
+		  /* skel_fd was dup'ed by create_dwfl.  We can close the
+		     original now.  */
+		  close (skel_fd);
+		}
 
 	      if (skel_dwfl != NULL)
 		{