From: Chen Ni Date: Wed, 15 May 2024 03:30:51 +0000 (+0800) Subject: HID: nvidia-shield: Add missing check for input_ff_create_memless X-Git-Tag: v6.10-rc3~5^2~13 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0a3f9f7fc59feb8a91a2793b8b60977895c72365;p=thirdparty%2Fkernel%2Flinux.git HID: nvidia-shield: Add missing check for input_ff_create_memless Add check for the return value of input_ff_create_memless() and return the error if it fails in order to catch the error. Fixes: 09308562d4af ("HID: nvidia-shield: Initial driver implementation with Thunderstrike support") Signed-off-by: Chen Ni Reviewed-by: Rahul Rameshbabu Signed-off-by: Jiri Kosina --- diff --git a/drivers/hid/hid-nvidia-shield.c b/drivers/hid/hid-nvidia-shield.c index 58b15750dbb0a..ff9078ad19611 100644 --- a/drivers/hid/hid-nvidia-shield.c +++ b/drivers/hid/hid-nvidia-shield.c @@ -283,7 +283,9 @@ static struct input_dev *shield_haptics_create( return haptics; input_set_capability(haptics, EV_FF, FF_RUMBLE); - input_ff_create_memless(haptics, NULL, play_effect); + ret = input_ff_create_memless(haptics, NULL, play_effect); + if (ret) + goto err; ret = input_register_device(haptics); if (ret)