From: Eric Blake Date: Thu, 28 Apr 2016 21:45:28 +0000 (-0600) Subject: qapi: Don't pass NULL to printf in string input visitor X-Git-Tag: v2.6.0-rc4~5^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0a40bdab0d48d9ce0c34bc2d319e44e92e0cc942;p=thirdparty%2Fqemu.git qapi: Don't pass NULL to printf in string input visitor Make sure the error message for visit_type_uint64() gracefully handles a NULL 'name' when called from the top level or a list context, as not all the world behaves like glibc in allowing NULL through a printf-family %s. Signed-off-by: Eric Blake Message-Id: <1461879932-9020-21-git-send-email-eblake@redhat.com> Signed-off-by: Markus Armbruster --- diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c index ab129536e47..5ea2d77b5ad 100644 --- a/qapi/string-input-visitor.c +++ b/qapi/string-input-visitor.c @@ -222,7 +222,7 @@ static void parse_type_int64(Visitor *v, const char *name, int64_t *obj, return; error: - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, name, + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, name ? name : "null", "an int64 value or range"); }