From: Eric Blake <eblake@redhat.com>
Date: Thu, 2 Jun 2011 22:38:38 +0000 (-0600)
Subject: lock: avoid leak on failure
X-Git-Tag: v0.9.2~19
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0a41733c13cadafc3ad90d57b8a8cc3c462e7e9d;p=thirdparty%2Flibvirt.git

lock: avoid leak on failure

Detected by Coverity.  Only possible on OOM situations.

* src/locking/lock_manager.c (virLockManagerPluginNew): Plug leak.
---

diff --git a/src/locking/lock_manager.c b/src/locking/lock_manager.c
index 6197fd404e..138cc91997 100644
--- a/src/locking/lock_manager.c
+++ b/src/locking/lock_manager.c
@@ -120,7 +120,7 @@ virLockManagerPluginPtr virLockManagerPluginNew(const char *name,
 {
     void *handle = NULL;
     virLockDriverPtr driver;
-    virLockManagerPluginPtr plugin;
+    virLockManagerPluginPtr plugin = NULL;
     const char *moddir = getenv("LIBVIRT_LOCK_MANAGER_PLUGIN_DIR");
     char *modfile = NULL;
 
@@ -182,6 +182,7 @@ virLockManagerPluginPtr virLockManagerPluginNew(const char *name,
     return plugin;
 
 cleanup:
+    VIR_FREE(plugin);
     VIR_FREE(modfile);
     if (handle)
         dlclose(handle);