From: Robert Haas <rhaas@postgresql.org>
Date: Thu, 15 Jan 2015 14:26:03 +0000 (-0500)
Subject: pg_standby: Avoid writing one byte beyond the end of the buffer.
X-Git-Tag: REL9_0_19~27
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0a67c00182be0a0c69eab365bfa4830f15be06d1;p=thirdparty%2Fpostgresql.git

pg_standby: Avoid writing one byte beyond the end of the buffer.

Previously, read() might have returned a length equal to the buffer
length, and then the subsequent store to buf[len] would write a
zero-byte one byte past the end.  This doesn't seem likely to be
a security issue, but there's some chance it could result in
pg_standby misbehaving.

Spotted by Coverity; patch by Michael Paquier, reviewed by me.
---

diff --git a/contrib/pg_standby/pg_standby.c b/contrib/pg_standby/pg_standby.c
index af4bb37e2b6..8687c810784 100644
--- a/contrib/pg_standby/pg_standby.c
+++ b/contrib/pg_standby/pg_standby.c
@@ -434,7 +434,7 @@ CheckForExternalTrigger(void)
 		return;
 	}
 
-	if ((len = read(fd, buf, sizeof(buf))) < 0)
+	if ((len = read(fd, buf, sizeof(buf) - 1)) < 0)
 	{
 		fprintf(stderr, "WARNING: could not read \"%s\": %s\n",
 				triggerPath, strerror(errno));