From: John Ferlan <jferlan@redhat.com>
Date: Thu, 8 Oct 2015 20:47:30 +0000 (-0400)
Subject: Revert "storage: Prior to creating a volume, refresh the pool"
X-Git-Tag: v1.3.0-rc1~191
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0a6e709c951a364fb3364040be9e6f0568577bf7;p=thirdparty%2Flibvirt.git

Revert "storage: Prior to creating a volume, refresh the pool"

This reverts commit fdda37608a6e22406fbdfe4ac0c573a96a8d0417.

This commit only manages a symptom of finding a buildRet failure
where a volume was not listed in the pool, but someone created the
volume outside of libvirt in the pool being managed by libvirt.
---

diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index 292ed9e13f..31b7095897 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -1805,15 +1805,6 @@ storageVolCreateXML(virStoragePoolPtr obj,
     if (virStorageVolCreateXMLEnsureACL(obj->conn, pool->def, voldef) < 0)
         goto cleanup;
 
-    /* While not perfect, refresh the list of volumes in the pool and
-     * then check that the incoming name isn't already in the pool.
-     */
-    if (backend->refreshPool) {
-        virStoragePoolObjClearVols(pool);
-        if (backend->refreshPool(obj->conn, pool) < 0)
-            goto cleanup;
-    }
-
     if (virStorageVolDefFindByName(pool, voldef->name)) {
         virReportError(VIR_ERR_STORAGE_VOL_EXIST,
                        _("'%s'"), voldef->name);