From: Francesco Chemolli <5175948+kinkie@users.noreply.github.com>
Date: Wed, 1 May 2024 18:46:18 +0000 (+0000)
Subject: Optimization: esiChoose constructor call copied parent pointer (#1803)
X-Git-Tag: SQUID_7_0_1~130
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0a96ce73a0133aa67e882e70412ff3423af9ac9a;p=thirdparty%2Fsquid.git

Optimization: esiChoose constructor call copied parent pointer (#1803)

Detected by Coverity. CID 1529569: Unnecessary object copies can affect
performance (COPY_INSTEAD_OF_MOVE).
---

diff --git a/src/esi/Esi.cc b/src/esi/Esi.cc
index c4e9194586..59339226cc 100644
--- a/src/esi/Esi.cc
+++ b/src/esi/Esi.cc
@@ -163,7 +163,7 @@ class esiChoose : public ESIElement
     MEMPROXY_CLASS(esiChoose);
 
 public:
-    esiChoose(esiTreeParentPtr);
+    esiChoose(const esiTreeParentPtr &);
     ~esiChoose() override;
 
     void render(ESISegment::Pointer) override;
@@ -1889,7 +1889,7 @@ esiChoose::~esiChoose()
     FinishAllElements(elements); // finish if not already done
 }
 
-esiChoose::esiChoose(esiTreeParentPtr aParent) :
+esiChoose::esiChoose(const esiTreeParentPtr & aParent) :
     elements(),
     chosenelement(-1),
     parent(aParent)