From: Marek Schimara <Marek.Schimara@bull.net>
Date: Wed, 15 Jun 2016 13:36:28 +0000 (+0200)
Subject: src/rrd_daemon.c: fix Coverity CID#32408 Missing unlock
X-Git-Tag: v1.7.0~42^2~47
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0ab27dc41d124b3b792ef83d18badf45e438c947;p=thirdparty%2Frrdtool-1.x.git

src/rrd_daemon.c: fix Coverity CID#32408 Missing unlock

        CWE-667 / https://cwe.mitre.org/data/definitions/667.html
---

diff --git a/src/rrd_daemon.c b/src/rrd_daemon.c
index 99774abd..9e3596ab 100644
--- a/src/rrd_daemon.c
+++ b/src/rrd_daemon.c
@@ -2277,10 +2277,12 @@ static int handle_request_create (HANDLER_PROTO) /* {{{ */
         rc = send_response(sock, RESP_ERR,
             "No permission to recursively create: %s\nDid you pass -R to the daemon?\n",
             dir);
+        pthread_mutex_unlock(&rrdfilecreate_lock);
         goto done;
     }
     if (rrd_mkdir_p(dir, 0755) != 0) {
         rc = send_response(sock, RESP_ERR, "Cannot create: %s\n", dir);
+        pthread_mutex_unlock(&rrdfilecreate_lock);
         goto done;
     }
   }