From: Zheng Liang Date: Tue, 24 Nov 2020 03:06:06 +0000 (+0800) Subject: gpio: arizona: disable pm_runtime in case of failure X-Git-Tag: v5.10~16^2~1^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0ac22098de6f9fd460ac1b1cbf6dbd324312161c;p=thirdparty%2Fkernel%2Flinux.git gpio: arizona: disable pm_runtime in case of failure pm_runtime_enable will increase power disable depth. Thus a pairing decrement is needed on the error handling path to keep it balanced. Fixes:27a49ed17e224(gpio: arizona: Add support for GPIOs that) Reported-by: Hulk Robot Signed-off-by: Zheng Liang Signed-off-by: Bartosz Golaszewski --- diff --git a/drivers/gpio/gpio-arizona.c b/drivers/gpio/gpio-arizona.c index 5bda38e0780f2..2bc173c352ce5 100644 --- a/drivers/gpio/gpio-arizona.c +++ b/drivers/gpio/gpio-arizona.c @@ -192,6 +192,7 @@ static int arizona_gpio_probe(struct platform_device *pdev) ret = devm_gpiochip_add_data(&pdev->dev, &arizona_gpio->gpio_chip, arizona_gpio); if (ret < 0) { + pm_runtime_disable(&pdev->dev); dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret); return ret;