From: Miod Vallat <miod.vallat@powerdns.com>
Date: Fri, 28 Feb 2025 15:38:39 +0000 (+0100)
Subject: Do not clear the domain list in getAllDomains.
X-Git-Tag: dnsdist-2.0.0-alpha1~53^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0acee96170e03385da0c3ed30679a2a29b81e06c;p=thirdparty%2Fpdns.git

Do not clear the domain list in getAllDomains.

Doing this causes incomplete information to be returned in multi-backend
configuration.
---

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index 8385bd1b0d..e67ceceb5f 100644
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -1813,8 +1813,6 @@ void LMDBBackend::getAllDomainsFiltered(vector<DomainInfo>* domains, const std::
 
 void LMDBBackend::getAllDomains(vector<DomainInfo>* domains, bool /* doSerial */, bool include_disabled)
 {
-  domains->clear();
-
   getAllDomainsFiltered(domains, [this, include_disabled](DomainInfo& di) {
     if (!getSerial(di) && !include_disabled) {
       return false;