From: Jukka Kurkela <jukka.kurkela@gmail.com>
Date: Sat, 10 Apr 2021 20:13:30 +0000 (+0300)
Subject: Limit onHover to chartArea (#8794)
X-Git-Tag: v3.1.0~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0ae0fd4b2a659f1ac3fde4ffd46608c3f747ca22;p=thirdparty%2FChart.js.git

Limit onHover to chartArea (#8794)
---

diff --git a/docs/configuration/interactions.md b/docs/configuration/interactions.md
index 2b7a44f9a..8ec5babb6 100644
--- a/docs/configuration/interactions.md
+++ b/docs/configuration/interactions.md
@@ -18,8 +18,8 @@ Namespace: `options`
 | Name | Type | Default | Description
 | ---- | ---- | ------- | -----------
 | `events` | `string[]` | `['mousemove', 'mouseout', 'click', 'touchstart', 'touchmove']` | The `events` option defines the browser events that the chart should listen to for. Each of these events trigger hover and are passed to plugins. [more...](#event-option)
-| `onHover` | `function` | `null` | Called when any of the events fire. Passed the event, an array of active elements (bars, points, etc), and the chart.
-| `onClick` | `function` | `null` | Called if the event is of type `'mouseup'` or `'click'`. Passed the event, an array of active elements, and the chart.
+| `onHover` | `function` | `null` | Called when any of the events fire over chartArea. Passed the event, an array of active elements (bars, points, etc), and the chart.
+| `onClick` | `function` | `null` | Called if the event is of type `'mouseup'`, `'click'` or '`'contextmenu'` over chartArea. Passed the event, an array of active elements, and the chart.
 
 ### Event Option
 
diff --git a/src/core/core.controller.js b/src/core/core.controller.js
index 34b342014..856ec56a3 100644
--- a/src/core/core.controller.js
+++ b/src/core/core.controller.js
@@ -1108,11 +1108,11 @@ class Chart {
     // This prevents recursion if the handler calls chart.update()
     me._lastEvent = null;
 
-    // Invoke onHover hook
-    callCallback(options.onHover, [e, active, me], me);
+    if (_isPointInArea(e, me.chartArea, me._minPadding)) {
+      // Invoke onHover hook
+      callCallback(options.onHover, [e, active, me], me);
 
-    if (e.type === 'mouseup' || e.type === 'click' || e.type === 'contextmenu') {
-      if (_isPointInArea(e, me.chartArea, me._minPadding)) {
+      if (e.type === 'mouseup' || e.type === 'click' || e.type === 'contextmenu') {
         callCallback(options.onClick, [e, active, me], me);
       }
     }