From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Date: Mon, 17 Feb 2025 14:16:12 +0000 (+0000)
Subject: iio: adc: ad7768-1: Move setting of val a bit later to avoid unnecessary return value... 
X-Git-Tag: v6.15-rc1~78^2~8^2~71
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0af1c801a15225304a6328258efbf2bee245c654;p=thirdparty%2Fkernel%2Flinux.git

iio: adc: ad7768-1: Move setting of val a bit later to avoid unnecessary return value check

The data used is all in local variables so there is no advantage
in setting *val = ret with the direct mode claim held.
Move it later to after error check.

Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://patch.msgid.link/20250217141630.897334-13-jic23@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---

diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
index 113703fb72454..c2ba357b82d85 100644
--- a/drivers/iio/adc/ad7768-1.c
+++ b/drivers/iio/adc/ad7768-1.c
@@ -370,12 +370,11 @@ static int ad7768_read_raw(struct iio_dev *indio_dev,
 			return ret;
 
 		ret = ad7768_scan_direct(indio_dev);
-		if (ret >= 0)
-			*val = ret;
 
 		iio_device_release_direct_mode(indio_dev);
 		if (ret < 0)
 			return ret;
+		*val = ret;
 
 		return IIO_VAL_INT;