From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 17 Nov 2023 14:10:57 +0000 (+0100)
Subject: dnsdist: Fix clang-tidy warnings
X-Git-Tag: rec-5.0.0-rc1~5^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0b01a95271c11e0a6d07fef4b0257f02097f6edd;p=thirdparty%2Fpdns.git

dnsdist: Fix clang-tidy warnings
---

diff --git a/pdns/dnsdist-lua-bindings.cc b/pdns/dnsdist-lua-bindings.cc
index a81c8fe45b..c0339deaba 100644
--- a/pdns/dnsdist-lua-bindings.cc
+++ b/pdns/dnsdist-lua-bindings.cc
@@ -795,8 +795,8 @@ void setupLuaBindings(LuaContext& luaCtx, bool client, bool configCheck)
     std::thread newThread(dnsdist::resolver::asynchronousResolver, std::move(hostname), [callback=std::move(callback)](const std::string& resolvedHostname, std::vector<ComboAddress>& ips) {
       LuaArray<ComboAddress> result;
       result.reserve(ips.size());
-      for (auto& entry : ips) {
-        result.emplace_back(result.size() + 1, std::move(entry));
+      for (const auto& entry : ips) {
+        result.emplace_back(result.size() + 1, entry);
       }
       {
         auto lua = g_lua.lock();