From: Rob Herring (Arm) Date: Wed, 31 Jul 2024 20:15:15 +0000 (-0600) Subject: net: mdio: Use of_property_count_u32_elems() to get property length X-Git-Tag: v6.12-rc1~232^2~339 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0b0e9cdb3d1f8fda823b592b0667b4b0595e2ba7;p=thirdparty%2Fkernel%2Flinux.git net: mdio: Use of_property_count_u32_elems() to get property length Replace of_get_property() with the type specific of_property_count_u32_elems() to get the property length. This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed. Signed-off-by: Rob Herring (Arm) Link: https://patch.msgid.link/20240731201514.1839974-2-robh@kernel.org Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c index 08e607f62e102..2f4fc664d2e12 100644 --- a/drivers/net/mdio/of_mdio.c +++ b/drivers/net/mdio/of_mdio.c @@ -390,7 +390,7 @@ EXPORT_SYMBOL(of_phy_get_and_connect); bool of_phy_is_fixed_link(struct device_node *np) { struct device_node *dn; - int len, err; + int err; const char *managed; /* New binding */ @@ -405,8 +405,7 @@ bool of_phy_is_fixed_link(struct device_node *np) return true; /* Old binding */ - if (of_get_property(np, "fixed-link", &len) && - len == (5 * sizeof(__be32))) + if (of_property_count_u32_elems(np, "fixed-link") == 5) return true; return false;