From: Michal Kalderon Date: Wed, 2 Sep 2020 16:57:35 +0000 (+0300) Subject: RDMA/qedr: Fix doorbell setting X-Git-Tag: v5.10-rc1~92^2~95 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0b1eddc1964351cd5ce57aff46853ed4ce9ebbff;p=thirdparty%2Flinux.git RDMA/qedr: Fix doorbell setting Change the doorbell setting so that the maximum value between the last and current value is set. This is to avoid doorbells being lost. Fixes: a7efd7773e31 ("qedr: Add support for PD,PKEY and CQ verbs") Link: https://lore.kernel.org/r/20200902165741.8355-3-michal.kalderon@marvell.com Signed-off-by: Michal Kalderon Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c index bf5fa8db7837a..1da0131d50425 100644 --- a/drivers/infiniband/hw/qedr/verbs.c +++ b/drivers/infiniband/hw/qedr/verbs.c @@ -989,7 +989,7 @@ int qedr_create_cq(struct ib_cq *ibcq, const struct ib_cq_init_attr *attr, /* Generate doorbell address. */ cq->db.data.icid = cq->icid; cq->db_addr = dev->db_addr + db_offset; - cq->db.data.params = DB_AGG_CMD_SET << + cq->db.data.params = DB_AGG_CMD_MAX << RDMA_PWM_VAL32_DATA_AGG_CMD_SHIFT; /* point to the very last element, passing it we will toggle */