From: Alyssa Ross Date: Fri, 14 Feb 2025 08:45:10 +0000 (+0100) Subject: configure: additionally get icu-uc from pkg-config X-Git-Tag: v6.14.0~33 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0b3e7284c7fa20dd27f8a584f8db417d1d6fa27b;p=thirdparty%2Fxfsprogs-dev.git configure: additionally get icu-uc from pkg-config Upstream libicu changed its pkgconfig files[0] in version 76 to require callers to call out to each .pc file they need for the libraries they want to link against. This apparently reduces overlinking, at a cost of needing the world to fix themselves up. This patch fixes the following build error with icu 76, also seen by Fedora[1]: /bin/ld: unicrash.o: undefined reference to symbol 'uiter_setString_76' /bin/ld: /lib/libicuuc.so.76: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status make[2]: *** [../include/buildrules:65: xfs_scrub] Error 1 make[1]: *** [include/buildrules:35: scrub] Error 2 Link: https://github.com/unicode-org/icu/commit/199bc827021ffdb43b6579d68e5eecf54c7f6f56 [0] Link: https://src.fedoraproject.org/rpms/xfsprogs/c/624b0fdf7b2a31c1a34787b04e791eee47c97340 [1] Signed-off-by: Alyssa Ross Reviewed-by: "Darrick J. Wong" --- diff --git a/m4/package_icu.m4 b/m4/package_icu.m4 index 3ccbe0cc..6b89c874 100644 --- a/m4/package_icu.m4 +++ b/m4/package_icu.m4 @@ -1,5 +1,5 @@ AC_DEFUN([AC_HAVE_LIBICU], - [ PKG_CHECK_MODULES([libicu], [icu-i18n], [have_libicu=yes], [have_libicu=no]) + [ PKG_CHECK_MODULES([libicu], [icu-i18n icu-uc], [have_libicu=yes], [have_libicu=no]) AC_SUBST(have_libicu) AC_SUBST(libicu_CFLAGS) AC_SUBST(libicu_LIBS)