From: Stefan Beller Date: Fri, 13 Feb 2015 21:18:49 +0000 (-0800) Subject: hex.c: reduce memory footprint of sha1_to_hex static buffers X-Git-Tag: v2.3.2~26^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0b868f0eecf4a5b4f25b5876e731f0b5456edc89;p=thirdparty%2Fgit.git hex.c: reduce memory footprint of sha1_to_hex static buffers 41 bytes is the exact number of bytes needed for having the returned hex string represented. 50 seems to be an arbitrary number, such that there are no benefits from alignment to certain address boundaries. Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano --- diff --git a/hex.c b/hex.c index bb402fbaa2..9ec5a3b325 100644 --- a/hex.c +++ b/hex.c @@ -51,7 +51,7 @@ int get_sha1_hex(const char *hex, unsigned char *sha1) char *sha1_to_hex(const unsigned char *sha1) { static int bufno; - static char hexbuffer[4][50]; + static char hexbuffer[4][41]; static const char hex[] = "0123456789abcdef"; char *buffer = hexbuffer[3 & ++bufno], *buf = buffer; int i;