From: Sami Kerola <kerolasa@iki.fi>
Date: Fri, 5 Sep 2014 22:17:19 +0000 (+0100)
Subject: renice: disallow --priority <arg> without pid argument
X-Git-Tag: v2.26-rc1~448^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0bb01bb0b7fc05d7eeb8a0117bc8fbecf54a88ce;p=thirdparty%2Futil-linux.git

renice: disallow --priority <arg> without pid argument

Earlier a lonely priority with an argument but without pid resulted to no
action and success, when the invocation should have failed.

$ renice --priority 42 ; echo $?
0

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/sys-utils/renice.c b/sys-utils/renice.c
index 06056802b1..2075d40762 100644
--- a/sys-utils/renice.c
+++ b/sys-utils/renice.c
@@ -131,14 +131,14 @@ main(int argc, char **argv)
 		}
 	}
 
-	if (argc < 2)
-		usage(stderr);
-
-	if (strcmp(*argv, "-n") == 0 || strcmp(*argv, "--priority") == 0) {
+	if (*argv && (strcmp(*argv, "-n") == 0 || strcmp(*argv, "--priority") == 0)) {
 		argc--;
 		argv++;
 	}
 
+	if (argc < 2)
+		usage(stderr);
+
 	prio = strtol(*argv, &endptr, 10);
 	if (*endptr)
 		usage(stderr);