From: Nick Porter <nick@portercomputing.co.uk>
Date: Wed, 3 Sep 2025 10:50:17 +0000 (+0100)
Subject: Pacify Coverity (CID #1520878)
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0bb54b265705cddffa9fdef57af1a45b3db1e81f;p=thirdparty%2Ffreeradius-server.git

Pacify Coverity (CID #1520878)

Coverity doesn't see that fd < 0 means the lock was released
---

diff --git a/src/modules/rlm_linelog/rlm_linelog.c b/src/modules/rlm_linelog/rlm_linelog.c
index 396b5abc6e..bb8812de6a 100644
--- a/src/modules/rlm_linelog/rlm_linelog.c
+++ b/src/modules/rlm_linelog/rlm_linelog.c
@@ -408,6 +408,8 @@ static int linelog_write(rlm_linelog_t const *inst, linelog_call_env_t const *ca
 		fd = exfile_open(inst->file.ef, path, inst->file.permissions, &offset);
 		if (fd < 0) {
 			RERROR("Failed to open %pV: %s", call_env->filename, fr_syserror(errno));
+
+			/* coverity[missing_unlock] */
 			return -1;
 		}