From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sun, 30 Jun 2013 08:45:09 +0000 (-0600)
Subject: Bug 3762: remove bogus WARNING in cache.log
X-Git-Tag: SQUID_3_3_6~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0bbc2362f30b053ff3bd698485677b9c389e28a2;p=thirdparty%2Fsquid.git

Bug 3762: remove bogus WARNING in cache.log

The warning is bogus for several reasons:
* it appears with memory-only cache configurations
* it only checks the size of first SwapDir (as seen in bug 3762)
* very large memory spaces are now possible which may make disk appear
  small by comparison.

Its usefulness in detecting memory and disk misconfigurations has long
been almosy nil. Removing this entirey to resolve the bogus noise in
the above mentioned legitimate configurations.
---

diff --git a/src/cache_cf.cc b/src/cache_cf.cc
index acbb491289..e624b71b3b 100644
--- a/src/cache_cf.cc
+++ b/src/cache_cf.cc
@@ -674,12 +674,6 @@ configDoConfigure(void)
         Config.Store.maxObjectSize = 0x7FFF0000;
     }
 #endif
-    if (0 == Store::Root().maxSize())
-        /* people might want a zero-sized cache on purpose */
-        (void) 0;
-    else if (Store::Root().maxSize() < Config.memMaxSize)
-        /* This is bogus. folk with NULL caches will want this */
-        debugs(3, DBG_CRITICAL, "WARNING cache_mem is larger than total disk cache space!");
 
     if (Config.Announce.period > 0) {
         Config.onoff.announce = 1;